On Tue, Jan 31, 2006 at 02:31:49PM -0800, Andrew Morton wrote:
> OK?
No.
> diff -puN
> include/linux/linkage.h~abstract-type-size-specification-for-assembly
> include/linux/linkage.h
> --- 25/include/linux/linkage.h~abstract-type-size-specification-for-assembly
> Tue Jan 31 14:30:58 2006
> +++ 25-akpm/include/linux/linkage.h Tue Jan 31 14:30:58 2006
> @@ -39,6 +39,11 @@
> ALIGN; \
> name:
>
> +#define ENDPROC(name) \
> + .type name, @function; \
> + END(name)
> +#define END(name) \
> + .size name, .-name
>
> #endif
No. On MIPS we need a .end directive as well; since the dawn of Linux I
have the following in include/asm-mips/asm.h:
#define END(function) \
.end function; \
.size function,.-function
And while we're at it, the ENTRY definition there isn't usable on MIPS
either; we need two different definitions for leaf and no-leaf functions
which again are in asm.h:
/*
* LEAF - declare leaf routine
*/
#define LEAF(symbol) \
.globl symbol; \
.align 2; \
.type symbol,@function; \
.ent symbol,0; \
symbol: .frame sp,0,ra
/*
* NESTED - declare nested routine entry point
*/
#define NESTED(symbol, framesize, rpc) \
.globl symbol; \
.align 2; \
.type symbol,@function; \
.ent symbol,0; \
symbol: .frame sp, framesize, rpc
Ralf
-
To unsubscribe from this list: send the line "unsubscribe linux-arch" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
