On Sat, Mar 11, 2006 at 05:11:06PM +0100, Sam Ravnborg wrote:
> In lib/string.c export all symbols that are not defines.
>...
> As an example I've done it for sparc64 but the same applies
> for most architectures.
A few comments:
1. it'd be nice to use #ifndef blah instead of #if !defined(blah)
2. I don't think we normally indent for preprocessor conditionals -
if we did, would we not have these function definitions indented?
3. I don't understand how these !defined things are supposed to solve
the problem. There are three cases, and use strcpy as an example:
a) an architecture decides to override the lib/string.c definition
with its own static inline function. In this case, it must
define __HAVE_ARCH_STRCPY to exclude the lib/string.c version.
In this case, the architecture may decide against exporting the
named function because it'll always be inlined.
b) an architecture decides to override the lib/string.c definition
with its own macro version. This case is essentially the same
as case (a).
c) an architecture decides to override the lib/string.c definition
with its own out of line version. It must define
__HAVE_ARCH_STRCPY as per (a), but it wants an export.
d) an architecture wishes to use the lib/string.c definition. It
must not define __HAVE_ARCH_STRCPY.
With these changes, case (a) requires an additional #define strcpy strcpy
to prevent the EXPORT_SYMBOL being used.
Since we have case (a) in the kernel sources, I don't see any additional
#defines being added to prevent these exports. Maybe you decided to
always cause lib/string.c to export them except for case (b) ?
All in all, I think this is a complex solution to something which should
be simple. We have the general rule that EXPORT_SYMBOLs should be local
to the code which provides the function - at least within the same file.
This change seems to be a step away from that.
I much prefer the current implementation where, if you define __HAVE_ARCH_foo
then foo is not defined nor exported by the core kernel.
--
Russell King
Linux kernel 2.6 ARM Linux - http://www.arm.linux.org.uk/
maintainer of: 2.6 Serial core
-
To unsubscribe from this list: send the line "unsubscribe linux-arch" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
