On Sun, May 21, 2006 at 09:31:14AM -0500, James Bottomley wrote:
> Signed-off-by: James Bottomley <[EMAIL PROTECTED]>
> 
> ---
> Although this is a simple move, the sh implementation looks bogus.
> dma_map_sg is this:
> 
[snip]

> which is about right for a simple physical==bus physical implementation.
> However, your accessor is:
> 
> #define sg_dma_address(sg)    (virt_to_bus((sg)->dma_address))
> 
> so you're calling virt_to_bus() on an already physical address.
> 
Yes, the virt_to_bus() is bogus, feel free to drop it. The rest looks
fine.
-
To unsubscribe from this list: send the line "unsubscribe linux-arch" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Reply via email to