On Fri, 2006-08-25 at 14:31 +0900, Paul Mundt wrote:
> I like the idea of asm-generic/page_size.h (though why not just use
> asm-generic/page.h?)

asm-generic/page.h looks good.  I'll give it a shot.

> and ripping that out from the architecture headers,
> though the mm/Kconfig bits look like something best left in the
> architecture Kconfigs.
> 
> PAGE_SHIFT is really the only thing of interest, and that can be handled
> without the CONFIG_PAGE_SIZE mess. The architectures that really care
> about it can use their current hacks or just check PAGE_SHIFT. 

I just changed this around a little bit so that only the architectures
that care see the prompt:

> choice
>         prompt "Kernel Page Size"
>         depends on IA64 || SPARC64 || PARISC || MIPS
>         default PAGE_SIZE_4KB if MIPS
>         default PAGE_SIZE_8KB if IA64 || SPARC64 || PARISC
> config PAGE_SIZE_4KB
...

That at least consolidates the four architectures.  I guess I could move
them back, but some of the help text was _really_ similar and it all
seemed pretty redundant.

It wouldn't be hard to move it back, though.  That would certainly work.

-- Dave

-
To unsubscribe from this list: send the line "unsubscribe linux-arch" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Reply via email to