On Fri, 2006-09-01 at 12:08 -0700, Dave Hansen wrote: > * Note that this moves the compiler.h define outside of the > #ifdef __KERNEL__, but that's OK because it has its own.
No it isn't OK -- compiler.h isn't listed in include/linux/Kbuild, and hence doesn't exist at _all_ outside the kernel. And why are you doing it? The userspace version of your new asm-generic/page.h still doesn't do anything _but_ include compiler.h and align.h, so why do you feel the need to move those inclusions outside the ifdef? Actually, I suppose it _is_ OK because asm-generic/page.h doesn't exist in userspace either, because it isn't listed in asm-generic/Kbuild. But I assume that was just an oversight on your part and you did mean to export it? There's a similar problem with the new <linux/align.h> which you create, don't (and probably shouldn't) add to the Kbuild file, and then include from outside the confines of #ifdef __KERNEL__. Also, if you're touching all this and making it generic then it's probably worth spelling 'KiB' and 'MiB' correctly throughout. It's powers of two, not powers of ten. It does look like you've correctly refrained from making the new PAGE_SIZE definitions visible to userspace, which is good. Userspace should be using sysconf(), not hardcoded PAGE_SIZE. -- dwmw2 - To unsubscribe from this list: send the line "unsubscribe linux-arch" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
