Hi David, On Thu, 14 Sep 2006 12:52:04 +0100 David Howells <[EMAIL PROTECTED]> wrote: > > Stephen Rothwell <[EMAIL PROTECTED]> wrote: > > > After this patch, you don't need to include <linux/compiler.h> any more > > (and, in fact, the file ends up essentially empty). > > True. I could possibly delete the whole file, depending on who else has > designs on it.
I think the patch consolidating PAGE_SIZE may want it. > > Is there a good reason to move this function out of asm-generic/page.h? > > So that all the general log2-based functions are grouped together was what I > was thinking (at least their primary interfaces). Except the get_order() interface is purely related to pages (the fact that you have reimplemented it using the log2-based functions is just an implementation detail. -- Cheers, Stephen Rothwell [EMAIL PROTECTED] http://www.canb.auug.org.au/~sfr/ - To unsubscribe from this list: send the line "unsubscribe linux-arch" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
