From: Andrew Morton <[EMAIL PROTECTED]> Date: Wed, 27 Sep 2006 09:18:30 -0700
> On Wed, 27 Sep 2006 11:31:32 +0200 > Martin Schwidefsky <[EMAIL PROTECTED]> wrote: > > > On Tue, 2006-09-26 at 17:11 -0700, Andrew Morton wrote: > > > I guess other architectures will need to do this. See > > > 01408c4939479ec46c15aa7ef6e2406be50eeeca and > > > 7c12d81134b130ccd4c286b434ca48c4cda71a2f for the rationale. > > > > Urgh, s390 does not have the problem that is does pad the leftover bytes > > in __copy_from_user_inatomic but that is does NOT pad the leftover bytes > > in __copy_from_user .. > > > > That permits users to read uninitialised kernel memory by appending to a file > from a bad address then reading the result back.... Right. But wrt. *_inatomic() issue, you only need to add the new logic to avoid zeroing at the end on a fault _iff_ kmap_atomic() is relevent on your platform. In particular, it's necessary if kmap_atomic() disables preemption or anything like that. So only a more limited set of platforms need to worry about this. As far as I can tell, this means: i386 FRV MIPS PPC SPARC32 I'll try to take care of sparc32. - To unsubscribe from this list: send the line "unsubscribe linux-arch" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
