On Wed, Oct 18, 2006 at 10:31:26AM +0100, Al Viro wrote: > On Wed, Oct 18, 2006 at 01:19:44PM +0400, Alexey Dobriyan wrote: > > > module.h is trickier. First of all, we want extern for wake_up_process(). > > > > When I came up with this to l-k, Nick and Christoph told me that duplicate > > proto sucks. So module.h/sched.h is > > a) uninline module_put() > > b) remove #include <linux/sched.h> > > Works for me... OTOH, wake_up_process() is not likely to change > prototype, so I'm not sure how strong that argument actually is.
Actually, it's pretty good argument. module_put() is not on hot paths and duplicate prototypes tend to diverge. > Anyway, that patch is obviously preliminary - at the very least > it needs be checked on more configs (and more targets - e.g. mips and > parisc hadn't been checked at all). configs. Is ftp://ftp.linux.org.uk/pub/people/viro/config/ still relevant? Or can you just post ls $CONFIGDIR ? - To unsubscribe from this list: send the line "unsubscribe linux-arch" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
