On Fri, 2006-11-10 at 23:47 +1100, Stephen Rothwell wrote: > On Fri, 10 Nov 2006 17:58:50 +1100 Benjamin Herrenschmidt <[EMAIL PROTECTED]> > wrote: > > > > Adds an arch specific struct dev_sysdata to struct device. This enables > > architecture to add specific fields to every device in the system, like > > DMA operation pointers, NUMA node ID, firmware specific data, etc... > > > > Signed-off-by: Benjamin Herrenschmidt <[EMAIL PROTECTED]> > > I would have done this by creating a single line asm-xxx/device.h containing > > #include <asm-generic/device.h>
A lot of archs will add custome things, so I felt it simpler that way, but I can do it via asm-generic... Anybody else preferring it that way ? > (except for asm-generic, of course) and then as each architecture implements > its own dev_sysdata, it can flesh out its asm/device.h. > > Also, I would use _ASM_<ARCH>_DEVICE_H, but thats just my preference. Because I'm overly lazy, I prefer just cp'ing an identical file to all asm-* dirs :-) Now I suppose it should be easy to do a little script to get it "right". I'll look into it for the patch renaming it to arch_data, I'll try to get that out later this morning. Ben. - To unsubscribe from this list: send the line "unsubscribe linux-arch" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
