On Fri, 6 Jul 2007, Russell King wrote: > On Fri, Jul 06, 2007 at 10:54:33AM -0700, [EMAIL PROTECTED] wrote: > > Potential impact: > > This adds another line to the Oops output, causing the first few lines to > > potentially scroll off the screen. This also adds a few more pointer > > dereferences in the Oops path, because it adds to the die_chain notifier > > chain, reducing the likelihood that the Oops will be printed if there is > > very bad memory corruption. > > Plus we don't get the utsname information on oops dumps during the kernel > initialisation. Not good - I'd rather keep things as is rather than loose > that facility which we've just gained on ARM.
Ok -- would it be more agreeable to make that a core_initcall? > Instead, can we have this as a call-able function which returns the > pointer, or just make the pointer global. That way we can also eliminate > the need for another additional line in the oops output. Hm. I don't really like the precedent being set for sucking arbitrary globals into the Oops message. It's not particularly extensible, and the additional line at the top doesn't seem like it will kill anyone... In particular, I am also considering a patch to print machine check statistics (if we took any machine check exceptions) at Oops-time, and I would implement that in a similar manner to this. joshua - To unsubscribe from this list: send the line "unsubscribe linux-arch" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
