-                       tlb_finish_mmu(*tlbp, tlb_start, start);
-
                        if (need_resched() ||
                                (i_mmap_lock && need_lockbreak(i_mmap_lock))) {
-                               if (i_mmap_lock) {
-                                       *tlbp = NULL;
+                               if (i_mmap_lock)
                                        goto out;

If we take this "goto out" path, then we'll miss out on calling
the tlb_finish_mmu() which you deleted just above.  At the very
least this will leave preemption disabled (since we'll miss calling
the put_cpu_var(mmu_gathers)).

I think I'm also missing the big picture view of what you are
doing here.

-Tony
-
To unsubscribe from this list: send the line "unsubscribe linux-arch" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Reply via email to