On Wed, 6 Feb 2008, Russell King wrote: > On Tue, Feb 05, 2008 at 10:54:54AM +0100, Haavard Skinnemoen wrote: > > sys_timerfd() has been removed, but avr32 still references it from its > > syscall table. > > > > Signed-off-by: Haavard Skinnemoen <[EMAIL PROTECTED]> > > --- > > On Mon, 04 Feb 2008 22:27:28 -0800 > > [EMAIL PROTECTED] wrote: > > > > > From: Davide Libenzi <[EMAIL PROTECTED]> > > > > > > Wires up the new timerfd API to the x86 family. > > > > Just one thing... > > > > > diff -puN > > > arch/x86/kernel/syscall_table_32.S~timerfd-v3-wire-the-new-timerfd-api-to-the-x86-family > > > arch/x86/kernel/syscall_table_32.S > > > --- > > > a/arch/x86/kernel/syscall_table_32.S~timerfd-v3-wire-the-new-timerfd-api-to-the-x86-family > > > +++ a/arch/x86/kernel/syscall_table_32.S > > > @@ -321,6 +321,8 @@ ENTRY(sys_call_table) > > > .long sys_epoll_pwait > > > .long sys_utimensat /* 320 */ > > > .long sys_signalfd > > > - .long sys_timerfd > > > > The next time you go and remove a system call, could you _please_ post > > a HUGE warning to linux-arch? Or just do a quick grep and fix it up.
Haavard, that was my fault not Andrew's. I thought that the patch setting it CONFIG_BROKEN carried a syscall unlink from tables. I should have grepped anyway. > Wasn't there a decision at a kernel summit that anything which adds > new syscalls should have a test program included so that architecture > maintainers can test the functionality on their architectures? It was always there, even before KS: http://www.xmailserver.org/timerfd-test2.c > I seem to remember that it came up because the merged timerfd was a > pile of utter crap which didn't have a hope in hells chance of working. Your pile of utter crap, was a typo that made the syscall return a truncated 32 bit "expired ticks" value (instead of 64 bit), and a wish from the manpages maintainer to have a way to retrieve the remaining time. - Davide - To unsubscribe from this list: send the line "unsubscribe linux-arch" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
