On 8/13/2010 4:36 AM, Datta, Shubhrajyoti wrote:
Minor comments feel free to ignore if you feel so.
Thanks for reviewing this, I'll address these in the next patch.
+ err = i2c_master_send(context->ti2c_client, buf, 1);
+ if (err< 0)
+ goto i2c_fail;
+ msleep(100);
Could you explain the time or have a #define XXX
Will add #define
+ gpio_direction_input(context->qcitp_gpio);
The result is not checked here.
I'll check the result.
--
Neil
--
Sent by an employee of the Qualcomm Innovation Center, Inc.
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum.
--
To unsubscribe from this list: send the line "unsubscribe linux-arm-msm" in
the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
