Even in cases where the consumer driver calls the regulator core with different voltage min/max values, the application of the various voltage constraints could result in the min/max voltage values passed to the regulator driver to be unchanged since the previous invocation.
Optimize these cases by not calling into the regulator driver and not sending incorrect/unnecessary voltage change notifications. Signed-off-by: Saravana Kannan <[email protected]> --- drivers/regulator/core.c | 10 ++++++++-- 1 files changed, 8 insertions(+), 2 deletions(-) diff --git a/drivers/regulator/core.c b/drivers/regulator/core.c index ba521f0..c2e67bb 100644 --- a/drivers/regulator/core.c +++ b/drivers/regulator/core.c @@ -1640,12 +1640,18 @@ int regulator_set_voltage(struct regulator *regulator, int min_uV, int max_uV) ret = regulator_check_voltage(rdev, &min_uV, &max_uV); if (ret < 0) goto out; - regulator->min_uV = min_uV; - regulator->max_uV = max_uV; + + if (regulator->min_uV == min_uV && regulator->max_uV == max_uV) + goto unlock; ret = rdev->desc->ops->set_voltage(rdev, min_uV, max_uV); + if (!ret) { + regulator->min_uV = min_uV; + regulator->max_uV = max_uV; + } out: _notifier_call_chain(rdev, REGULATOR_EVENT_VOLTAGE_CHANGE, NULL); +unlock: mutex_unlock(&rdev->mutex); return ret; } -- 1.7.1.1 -- Sent by an employee of the Qualcomm Innovation Center, Inc. The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum. -- To unsubscribe from this list: send the line "unsubscribe linux-arm-msm" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html
