Hello.

Pavankumar Kondeti wrote:

Signed-off-by: Pavankumar Kondeti <[email protected]>
[...]

diff --git a/drivers/usb/otg/msm_otg.c b/drivers/usb/otg/msm_otg.c
index 425418d..fe040a2 100644
--- a/drivers/usb/otg/msm_otg.c
+++ b/drivers/usb/otg/msm_otg.c
@@ -167,6 +167,32 @@ put_3p3:
        return rc;
 }
+#ifdef CONFIG_PM_SLEEP
+static int usb_phy_susp_dig_vol = 500000;

What's the point of making this variable? It doesn't seem to be changed anywhere...

@@ -489,6 +516,10 @@ static int msm_otg_suspend(struct msm_otg *motg)
         */
        writel(readl(USB_USBCMD) | ASYNC_INTR_CTRL | ULPI_STP_CTRL, USB_USBCMD);
+ if (motg->pdata->phy_type == SNPS_28NM_INTEGRATED_PHY &&
+                       motg->pdata->phy_type == OTG_PMIC_CONTROL)

   This is never true, I guess. Did you mean || ISO &&?

+               writel(readl(USB_PHY_CTRL) | PHY_RETEN, USB_PHY_CTRL);
+
        clk_disable(motg->pclk);
        clk_disable(motg->clk);
        if (motg->core_clk)
@@ -497,6 +528,12 @@ static int msm_otg_suspend(struct msm_otg *motg)
        if (!IS_ERR(motg->pclk_src))
                clk_disable(motg->pclk_src);
+ if (motg->pdata->phy_type == SNPS_28NM_INTEGRATED_PHY &&
+                       motg->pdata->phy_type == OTG_PMIC_CONTROL) {

   This is never true either...

+               msm_hsusb_ldo_enable(0);
+               msm_hsusb_config_vddcx(0);
+       }
+
        if (device_may_wakeup(otg->dev))
                enable_irq_wake(motg->irq);
        if (bus)
@@ -527,6 +564,13 @@ static int msm_otg_resume(struct msm_otg *motg)
        if (motg->core_clk)
                clk_enable(motg->core_clk);
+ if (motg->pdata->phy_type == SNPS_28NM_INTEGRATED_PHY &&
+                       motg->pdata->phy_type == OTG_PMIC_CONTROL) {

   Neither is this one...

WBR, Sergei

--
To unsubscribe from this list: send the line "unsubscribe linux-arm-msm" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Reply via email to