Hi Hugh,

+ unsigned long enable;
+ int err;
+
+ err = kstrtoul(buf, 10,&enable);
+ if (err< 0)
+ return err;
+ if (enable>= 1)
+ return -EINVAL;

I haven't studied the patch itself, I'm still worrying about the concept.
But this caught my eye just before hitting Send: I don't think we need
a tunable which only accepts the value 0 ;)

Okay. I can correct this to accept any non-zero value. Is that okay ?

I missed that to reply earlier. This was suggested by Andrew. And I think that is okay as displaying any non-zero value to user via this knob may not be completely right.



+ use_deferrable_timer = enable;



--
Chintan Pandya

QUALCOMM INDIA, on behalf of Qualcomm Innovation Center, Inc. is a
member of the Code Aurora Forum, hosted by The Linux Foundation
--
To unsubscribe from this list: send the line "unsubscribe linux-arm-msm" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Reply via email to