On Tuesday, September 28, 2010 05:40:22 am James Morris wrote: > BoxySeq is still very far away from suitable for end > users, but I've decided to post an update here to let > people know that I'm still working on it :-)
Sweet! Nice work! Here's a couple of minor patches. -gabriel
From 76b45b3df02ab00094539698aceff860f7164edd Mon Sep 17 00:00:00 2001 From: Gabriel M. Beddingfield <[email protected]> Date: Tue, 28 Sep 2010 07:30:35 -0500 Subject: [PATCH 1/2] gui: link to lib target 'boxyseq' instead of .a file. The old method of linking to ${BoxySeq_SOURCE_DIR}/libboxyseq/libboxyseq.a failed in two cases: * Parallel builds (CMake doesn't calculate that boxyseq_gui depends on libboxyseq) * Out-of-tree builds (Looking for the lib in SOURCE_DIR instead of BINARY_DIR). By linking to the target name (boxyseq), CMake will handle all of this for us. --- boxyseq_gui/CMakeLists.txt | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/boxyseq_gui/CMakeLists.txt b/boxyseq_gui/CMakeLists.txt index 4eb7e2d..19dcc34 100644 --- a/boxyseq_gui/CMakeLists.txt +++ b/boxyseq_gui/CMakeLists.txt @@ -15,4 +15,4 @@ file (GLOB BOXYSEQ_GUI_SOURCES *.c) add_executable(boxyseq_gui ${BOXYSEQ_GUI_SOURCES}) -target_link_libraries(boxyseq_gui ${BoxySeq_SOURCE_DIR}/libboxyseq/libboxyseq.a ${GTK2_LIBRARIES} ${JACK_LIBRARIES}) +target_link_libraries(boxyseq_gui boxyseq ${GTK2_LIBRARIES} ${JACK_LIBRARIES}) -- 1.7.0.4
From 82f5329372b6ff34407cea120fad57d18407c459 Mon Sep 17 00:00:00 2001 From: Gabriel M. Beddingfield <[email protected]> Date: Tue, 28 Sep 2010 07:34:36 -0500 Subject: [PATCH 2/2] main: Suppress printf() compiler warning about sizeof() return type. Compiler was complaining that %ld and sizeof(event) [unsigned] were a mismatch. Worked around by making printf() look for an unsigned, and casting it to a longer integer. --- boxyseq_gui/main.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/boxyseq_gui/main.c b/boxyseq_gui/main.c index 5110290..d668081 100644 --- a/boxyseq_gui/main.c +++ b/boxyseq_gui/main.c @@ -176,7 +176,7 @@ printf("-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=\n"); jackdata_shutdown(jd); - printf("sizeof(event):%ld\n",sizeof(event)); + printf("sizeof(event):%lu\n", (unsigned long int)sizeof(event)); jackdata_free(jd); -- 1.7.0.4
_______________________________________________ Linux-audio-dev mailing list [email protected] http://lists.linuxaudio.org/listinfo/linux-audio-dev
