On Wed, 24 Mar 2004 22:09:46 +0100 (CET) Tim Goetze <[EMAIL PROTECTED]> wrote:
> [Jesse Chappell] > > >Tim Goetze wrote on Wed, 24-Mar-2004: > > > > > [Jesse Chappell] > > > > > >The stretch program was not properly clamping the output from > > > >-1.0 -> 1.0 yielding to terrible cracks upon writing as 16bit > > > >wave files when the output is clipped. The fact that non-clipping > > > >(but very close to) input yielded clipping output is another issue, > > > >but not crucial. > > > > > > > >I've attached a patch that fixes the problem. > > > > > > applied, thanks. > > > >I just realized that you may not want to clamp if your output > >is a 32 bit float or double, as it is fully capable of handling > >the value as produced. For instance, if (well, when) we suck this > >algorithm into ardour we don't need to clamp, as our internal > >format is float. > > true. i'll make it an option. Correct me if I'm wrong, but isn't clipping only a problem when converting to integer PCM sound file. If that is the case, you can leave the data unclipped and let libsndfile do the clipping by using this: http://www.mega-nerd.com/libsndfile/command.html#SFC_SET_CLIPPING Erik -- +-----------------------------------------------------------+ Erik de Castro Lopo [EMAIL PROTECTED] (Yes it's valid) +-----------------------------------------------------------+ "In my opinion, shareware tends to combine the worst of commercial software (no sources) with the worst of free software (no finishing touches). I simply do not believe in the shareware market at all." -- Linus Torvalds
