Paul Coccoli wrote:

> I wouldn't bother with openRead/Write; just pass the mode in to open
> like in the ctor.

The open/close methods are provided so a single Sndfile object
can be opened and closed multiple times. I was also going to
make the copy constructor and asignment operator private so
they can't be misused.

> I also second keeping the implementation entirely in the header (if it
> really is a light wrapper) and put "inline" in front of each method
> definition.

Thats was the idea from the start. I light-weight wrapper.

> SndFile::strerror() should maybe take an int arg (the value returned
> by SndFile::error()) and be declared as a static method?

Good catch.  Thanks. 

Erik
-- 
+-----------------------------------------------------------+
  Erik de Castro Lopo
+-----------------------------------------------------------+
"To me C++ seems to be a language that has sacrificed orthogonality
and elegance for random expediency." -- Meilir Page-Jones

Reply via email to