Hard to give this a meaningful review - particularly the first patch,
a large part of which seemed to be moving functionality from one file to
another. But slowly reading along, at least this smells like an error:
Quoting Amy Griffis ([EMAIL PROTECTED]):
> +/* Initialize a watch entry. */
> +static inline struct audit_watch *audit_init_watch(char *path)
> +{
> + struct audit_watch *watch;
> +
> + watch = kzalloc(sizeof(*watch), GFP_KERNEL);
> + if (unlikely(!watch))
> + return ERR_PTR(-ENOMEM);
...
> + watch = audit_init_watch(path);
> + if (unlikely(IS_ERR(watch)))
> + return PTR_ERR(watch);
Ok, but
> + new = audit_init_watch(path);
> + if (unlikely(!new)) {
> + kfree(path);
> + return ERR_PTR(-ENOMEM);
> + }
not ok
-serge
--
Linux-audit mailing list
[email protected]
https://www.redhat.com/mailman/listinfo/linux-audit
