Steve Grubb said the following on 2008-08-05 9:59:
>
> Right, but I don't see where it gets set to a 1.
>
Thank you for your suggestion.
I found the audit_permadded is set to 1 in audit_setup_perms() and setopt()
after the AUDIT_PERM field.
But I think it is not enough.
When the watch is added and AUDIT_PERM is not added, the perm r,w,x,a should be
added by kernel default.
So I think the audit_permadded should be set to 1 after a watch added.
I make a new patch for it. The "key" patch and new patch should use together.
Subject: [PATCH] When the watch is set, the audit_permadded should be set to 1
Signed-off-by: Zhang Xiliang <[EMAIL PROTECTED]>
---
lib/libaudit.c | 6 ++++++
1 files changed, 6 insertions(+), 0 deletions(-)
diff --git a/lib/libaudit.c b/lib/libaudit.c
index 71267de..9a317c5 100644
--- a/lib/libaudit.c
+++ b/lib/libaudit.c
@@ -580,6 +580,8 @@ int audit_add_watch_dir(int type, struct audit_rule_data
**rulep,
rule->fieldflags[1] = AUDIT_EQUAL;
rule->values[1] = AUDIT_PERM_READ | AUDIT_PERM_WRITE |
AUDIT_PERM_EXEC | AUDIT_PERM_ATTR;
+
+ audit_permadded = 1;
return 0;
}
@@ -941,6 +943,10 @@ int audit_rule_fieldpair_data(struct audit_rule_data
**rulep, const char *pair,
rule = *rulep;
}
strncpy(&rule->buf[offset], v, vlen);
+
+ if(flags && (AUDIT_WATCH || AUDIT_DIR))
+ audit_permadded = 1;
+
break;
case AUDIT_ARCH:
if (audit_syscalladded)
--
Linux-audit mailing list
[email protected]
https://www.redhat.com/mailman/listinfo/linux-audit
