On Wed, Nov 20, 2013 at 02:07:58PM -0800, William Roberts wrote: > On Wed, Nov 20, 2013 at 2:03 PM, William Roberts > <[email protected]> wrote: > > On Wed, Nov 20, 2013 at 1:47 PM, Richard Guy Briggs <[email protected]> wrote: > >> On Thu, Nov 14, 2013 at 08:56:57AM +0530, Paul Davies C wrote: > >>> + if (mm) { > >>> + down_read(&mm->mmap_sem); > >>> + if (mm->exe_file) > >>> + audit_log_d_path(ab, " exe=", > >>> &mm->exe_file->f_path); > >>> + up_read(&mm->mmap_sem); > >>> + } > > <snip> > One other thing that I know Steve Grubb is picky on, is the field > still needs to be there even if mm is null. We can't have > disappearing fields. On error conditions, I've been doing > <fieldname>=(null) on my patches.
Agreed. - RGB -- Richard Guy Briggs <[email protected]> Senior Software Engineer, Kernel Security, AMER ENG Base Operating Systems, Red Hat Remote, Ottawa, Canada Voice: +1.647.777.2635, Internal: (81) 32635, Alt: +1.613.693.0684x3545 -- Linux-audit mailing list [email protected] https://www.redhat.com/mailman/listinfo/linux-audit
