On 12/01/2014 02:09 PM, Steve Grubb wrote: > Hi Tony, > > On Friday, August 29, 2014 01:16:00 PM Tony Jones wrote: >> Add support for ppc64le. >> >> $ uname -a >> Linux cabernet 3.12.26-3-default #1 SMP Mon Aug 18 15:07:30 UTC 2014 >> (d318f3a) ppc64le ppc64le ppc64le GNU/Linux >> >> Without this, perf trace and auditctl fail. There is no 32 bit (ppcle). >> >> Signed-off-by: Tony Jones <[email protected]> >> --- >> >> Index: trunk/lib/libaudit.c >> =================================================================== >> --- trunk/lib/libaudit.c (revision 1011) >> +++ trunk/lib/libaudit.c (working copy) >> @@ -1195,6 +1195,11 @@ >> return -6; >> break; >> #endif >> + case MACH_PPC64LE: >> + if (bits != __AUDIT_ARCH_64BIT) >> + return -6; >> + break; >> + >> case MACH_86_64: /* fallthrough */ >> case MACH_PPC64: /* fallthrough */ >> case MACH_S390X: /* fallthrough */ >> Index: trunk/lib/libaudit.h >> =================================================================== >> --- trunk/lib/libaudit.h (revision 1011) >> +++ trunk/lib/libaudit.h (working copy) >> @@ -356,6 +356,9 @@ >> #define AUDIT_ARCH_AARCH64 (EM_AARCH64|__AUDIT_ARCH_64BIT| > __AUDIT_ARCH_LE) >> #endif >> >> +#ifndef AUDIT_ARCH_PPC64LE >> +#define AUDIT_ARCH_PPC64LE (EM_PPC64|__AUDIT_ARCH_64BIT|__AUDIT_ARCH_LE) >> +#endif > > Is this ^^^ define upstream or in some public branch? > > -Steve
Mainline kernel reports ppc64le (per a0588015deab1844261b27a67ae6f5b910fe2830) but there is no matching AUDIT_ARCH_PPC64LE. Eric just pinged me on irc about it. Fix to add it to include/uapi/linux/audit.h shoudld probably go upstream. -- Linux-audit mailing list [email protected] https://www.redhat.com/mailman/listinfo/linux-audit
