On 2017-06-12 14:33, Derek Robson wrote: > Fixed checkpatch.pl warnings of "function definition argument FOO > should also have an identifier name" > > Signed-off-by: Derek Robson <[email protected]>
Sounds reasonable. Reviewed-by: Richard Guy Briggs <[email protected]> > --- > kernel/audit.h | 28 ++++++++++++++-------------- > 1 file changed, 14 insertions(+), 14 deletions(-) > > diff --git a/kernel/audit.h b/kernel/audit.h > index ddfce2ea4891..90b891eea204 100644 > --- a/kernel/audit.h > +++ b/kernel/audit.h > @@ -247,13 +247,13 @@ struct audit_netlink_list { > struct sk_buff_head q; > }; > > -int audit_send_list(void *); > +int audit_send_list(void *_dest); > > extern int selinux_audit_rule_update(void); > > extern struct mutex audit_filter_mutex; > -extern int audit_del_rule(struct audit_entry *); > -extern void audit_free_rule_rcu(struct rcu_head *); > +extern int audit_del_rule(struct audit_entry *entry); > +extern void audit_free_rule_rcu(struct rcu_head *head); > extern struct list_head audit_filter_list[]; > > extern struct audit_entry *audit_dupe_rule(struct audit_krule *old); > @@ -301,17 +301,17 @@ extern int audit_exe_compare(struct task_struct *tsk, > struct audit_fsnotify_mark > #endif /* CONFIG_AUDIT_WATCH */ > > #ifdef CONFIG_AUDIT_TREE > -extern struct audit_chunk *audit_tree_lookup(const struct inode *); > -extern void audit_put_chunk(struct audit_chunk *); > -extern bool audit_tree_match(struct audit_chunk *, struct audit_tree *); > -extern int audit_make_tree(struct audit_krule *, char *, u32); > -extern int audit_add_tree_rule(struct audit_krule *); > -extern int audit_remove_tree_rule(struct audit_krule *); > +extern struct audit_chunk *audit_tree_lookup(const struct inode *inode); > +extern void audit_put_chunk(struct audit_chunk *chunk); > +extern bool audit_tree_match(struct audit_chunk *chunk, struct audit_tree > *tree); > +extern int audit_make_tree(struct audit_krule *rule, char *pathname, u32 op); > +extern int audit_add_tree_rule(struct audit_krule *rule); > +extern int audit_remove_tree_rule(struct audit_krule *rule); > extern void audit_trim_trees(void); > extern int audit_tag_tree(char *old, char *new); > -extern const char *audit_tree_path(struct audit_tree *); > -extern void audit_put_tree(struct audit_tree *); > -extern void audit_kill_trees(struct list_head *); > +extern const char *audit_tree_path(struct audit_tree *tree); > +extern void audit_put_tree(struct audit_tree *tree); > +extern void audit_kill_trees(struct list_head *list); > #else > #define audit_remove_tree_rule(rule) BUG() > #define audit_add_tree_rule(rule) -EINVAL > @@ -323,7 +323,7 @@ extern void audit_kill_trees(struct list_head *); > #define audit_kill_trees(list) BUG() > #endif > > -extern char *audit_unpack_string(void **, size_t *, size_t); > +extern char *audit_unpack_string(void **bufp, size_t *remain, size_t len); > > extern pid_t audit_sig_pid; > extern kuid_t audit_sig_uid; > @@ -333,7 +333,7 @@ extern int audit_filter(int msgtype, unsigned int > listtype); > > #ifdef CONFIG_AUDITSYSCALL > extern int audit_signal_info(int sig, struct task_struct *t); > -extern void audit_filter_inodes(struct task_struct *, struct audit_context > *); > +extern void audit_filter_inodes(struct task_struct *tsk, struct > audit_context *ctx); > extern struct list_head *audit_killed_trees(void); > #else > #define audit_signal_info(s,t) AUDIT_DISABLED > -- > 2.13.0 > > -- > Linux-audit mailing list > [email protected] > https://www.redhat.com/mailman/listinfo/linux-audit - RGB -- Richard Guy Briggs <[email protected]> Sr. S/W Engineer, Kernel Security, Base Operating Systems Remote, Ottawa, Red Hat Canada IRC: rgb, SunRaycer Voice: +1.647.777.2635, Internal: (81) 32635 -- Linux-audit mailing list [email protected] https://www.redhat.com/mailman/listinfo/linux-audit
