On Fri, Apr 3, 2020 at 3:56 AM Amol Grover <[email protected]> wrote: > On Thu, Apr 02, 2020 at 08:56:36AM -0400, Paul Moore wrote: > > On Thu, Apr 2, 2020 at 1:57 AM Amol Grover <[email protected]> wrote: > > > task_struct::cred is only used task-synchronously and does > > > not require any RCU locks, hence, rcu_dereference_check is > > > not required to read from it. > > > > > > Suggested-by: Jann Horn <[email protected]> > > > Co-developed-by: Joel Fernandes (Google) <[email protected]> > > > Signed-off-by: Joel Fernandes (Google) <[email protected]> > > > Signed-off-by: Amol Grover <[email protected]> > > > --- > > > kernel/auditsc.c | 15 +++++---------- > > > 1 file changed, 5 insertions(+), 10 deletions(-) > > > > This is the exact same patch I ACK'd back in February, yes? > > > > https://lore.kernel.org/linux-audit/CAHC9VhQCbg1V290bYEZM+izDPRpr=xyxakohndamphkbbfg...@mail.gmail.com > > > > Hi Paul, > > That's correct. I've resend the series out of the fear that the first 2 > patches might've gotten lost as it's been almost a month since I last > sent them. Could you please ack this again, and if you don't mind could > you please go through the other 2 patches and ack them aswell?
If you hadn't changed the patch at all, and it doesn't look like you did, you could have (and likely should have) just carried over my ACK. Regardless, I'll re-ACK it now (below). As far as the other two patches are concerned, they look okay to me but I would defer my ACK to maintainer of that code. Acked-by: Paul Moore <[email protected]> -- paul moore www.paul-moore.com -- Linux-audit mailing list [email protected] https://www.redhat.com/mailman/listinfo/linux-audit
