Hi Casey, I love your patch! Yet something to improve:
[auto build test ERROR on nf/master] [also build test ERROR on linus/master v5.13-rc6] [cannot apply to security/next-testing pcmoore-audit/next nf-next/master next-20210616] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch] url: https://github.com/0day-ci/linux/commits/Casey-Schaufler/LSM-Infrastructure-management-of-the-sock-security/20210616-133254 base: https://git.kernel.org/pub/scm/linux/kernel/git/pablo/nf.git master config: m68k-randconfig-r021-20210615 (attached as .config) compiler: m68k-linux-gcc (GCC) 9.3.0 reproduce (this is a W=1 build): wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # https://github.com/0day-ci/linux/commit/c6c28a65377a02c1aa05846e32c56cb015da9904 git remote add linux-review https://github.com/0day-ci/linux git fetch --no-tags linux-review Casey-Schaufler/LSM-Infrastructure-management-of-the-sock-security/20210616-133254 git checkout c6c28a65377a02c1aa05846e32c56cb015da9904 # save the attached .config to linux build tree COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=m68k If you fix the issue, kindly add following tag as appropriate Reported-by: kernel test robot <[email protected]> All errors (new ones prefixed by >>): In file included from include/linux/fsnotify.h:16, from fs/configfs/dir.c:14: >> include/linux/audit.h:557:1: error: expected identifier or '(' before '+' >> token 557 | +static inline struct audit_context *audit_alloc_local(gfp_t gfpflags) | ^ -- In file included from include/linux/fsnotify.h:16, from fs/cachefiles/namei.c:12: >> include/linux/audit.h:557:1: error: expected identifier or '(' before '+' >> token 557 | +static inline struct audit_context *audit_alloc_local(gfp_t gfpflags) | ^ fs/cachefiles/namei.c: In function 'cachefiles_walk_to_object': fs/cachefiles/namei.c:499:16: warning: variable 'start' set but not used [-Wunused-but-set-variable] 499 | unsigned long start; | ^~~~~ fs/cachefiles/namei.c: In function 'cachefiles_get_directory': fs/cachefiles/namei.c:768:16: warning: variable 'start' set but not used [-Wunused-but-set-variable] 768 | unsigned long start; | ^~~~~ fs/cachefiles/namei.c: In function 'cachefiles_check_active': fs/cachefiles/namei.c:879:16: warning: variable 'start' set but not used [-Wunused-but-set-variable] 879 | unsigned long start; | ^~~~~ -- In file included from fs/pipe.c:23: >> include/linux/audit.h:557:1: error: expected identifier or '(' before '+' >> token 557 | +static inline struct audit_context *audit_alloc_local(gfp_t gfpflags) | ^ fs/pipe.c:741:15: warning: no previous prototype for 'account_pipe_buffers' [-Wmissing-prototypes] 741 | unsigned long account_pipe_buffers(struct user_struct *user, | ^~~~~~~~~~~~~~~~~~~~ fs/pipe.c:747:6: warning: no previous prototype for 'too_many_pipe_buffers_soft' [-Wmissing-prototypes] 747 | bool too_many_pipe_buffers_soft(unsigned long user_bufs) | ^~~~~~~~~~~~~~~~~~~~~~~~~~ fs/pipe.c:754:6: warning: no previous prototype for 'too_many_pipe_buffers_hard' [-Wmissing-prototypes] 754 | bool too_many_pipe_buffers_hard(unsigned long user_bufs) | ^~~~~~~~~~~~~~~~~~~~~~~~~~ fs/pipe.c:761:6: warning: no previous prototype for 'pipe_is_unprivileged_user' [-Wmissing-prototypes] 761 | bool pipe_is_unprivileged_user(void) | ^~~~~~~~~~~~~~~~~~~~~~~~~ fs/pipe.c:1231:5: warning: no previous prototype for 'pipe_resize_ring' [-Wmissing-prototypes] 1231 | int pipe_resize_ring(struct pipe_inode_info *pipe, unsigned int nr_slots) | ^~~~~~~~~~~~~~~~ vim +557 include/linux/audit.h 553 554 extern int audit_n_rules; 555 extern int audit_signals; 556 #else /* CONFIG_AUDITSYSCALL */ > 557 +static inline struct audit_context *audit_alloc_local(gfp_t gfpflags) 558 { 559 return NULL; 560 } 561 static inline void audit_free_context(struct audit_context *context) 562 { } 563 static inline int audit_alloc(struct task_struct *task) 564 { 565 return 0; 566 } 567 static inline void audit_free(struct task_struct *task) 568 { } 569 static inline void audit_syscall_entry(int major, unsigned long a0, 570 unsigned long a1, unsigned long a2, 571 unsigned long a3) 572 { } 573 static inline void audit_syscall_exit(void *pt_regs) 574 { } 575 static inline bool audit_dummy_context(void) 576 { 577 return true; 578 } 579 static inline void audit_set_context(struct task_struct *task, struct audit_context *ctx) 580 { } 581 static inline struct audit_context *audit_context(void) 582 { 583 return NULL; 584 } 585 static inline struct filename *audit_reusename(const __user char *name) 586 { 587 return NULL; 588 } 589 static inline void audit_getname(struct filename *name) 590 { } 591 static inline void audit_inode(struct filename *name, 592 const struct dentry *dentry, 593 unsigned int aflags) 594 { } 595 static inline void audit_file(struct file *file) 596 { 597 } 598 static inline void audit_inode_parent_hidden(struct filename *name, 599 const struct dentry *dentry) 600 { } 601 static inline void audit_inode_child(struct inode *parent, 602 const struct dentry *dentry, 603 const unsigned char type) 604 { } 605 static inline void audit_core_dumps(long signr) 606 { } 607 static inline void audit_seccomp(unsigned long syscall, long signr, int code) 608 { } 609 static inline void audit_seccomp_actions_logged(const char *names, 610 const char *old_names, int res) 611 { } 612 static inline void audit_ipc_obj(struct kern_ipc_perm *ipcp) 613 { } 614 static inline void audit_ipc_set_perm(unsigned long qbytes, uid_t uid, 615 gid_t gid, umode_t mode) 616 { } 617 static inline void audit_bprm(struct linux_binprm *bprm) 618 { } 619 static inline int audit_socketcall(int nargs, unsigned long *args) 620 { 621 return 0; 622 } 623 --- 0-DAY CI Kernel Test Service, Intel Corporation https://lists.01.org/hyperkitty/list/[email protected]
.config.gz
Description: application/gzip
-- Linux-audit mailing list [email protected] https://listman.redhat.com/mailman/listinfo/linux-audit
