On 01/15/2014 01:33 AM, Geert Uytterhoeven wrote:
{,set}page_address() are macros if WANT_PAGE_VIRTUAL. If !WANT_PAGE_VIRTUAL, they're plain C functions.If someone calls them with a void *, this pointer is auto-converted to struct page * if !WANT_PAGE_VIRTUAL, but causes a build failure on architectures using WANT_PAGE_VIRTUAL (arc, m68k and sparc): drivers/md/bcache/bset.c: In function ‘__btree_sort’: drivers/md/bcache/bset.c:1190: warning: dereferencing ‘void *’ pointer drivers/md/bcache/bset.c:1190: error: request for member ‘virtual’ in something not a structure or union Convert them to static inline functions to fix this. There are already plenty of users of struct page members inside <linux/mm.h>, so there's no reason to keep them as macros. Signed-off-by: Geert Uytterhoeven <[email protected]>
Tested-by: Guenter Roeck <[email protected]> That also fixes the problem seen in stable-queue for 3.10 and 3.12, so it may be a better fix for the problem seen there than the patch provided by Michael. Guenter -- To unsubscribe from this list: send the line "unsubscribe linux-bcache" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html
