There is a typo here where it uses ";" instead of "?:".  The result is
that bch2_fs_fs_io_direct_init() is called unconditionally and the errors
from it are not checked.

Fixes: 0060c68159fc ("bcachefs: Split up fs-io.[ch]")
Signed-off-by: Dan Carpenter <[email protected]>
---
 fs/bcachefs/super.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/fs/bcachefs/super.c b/fs/bcachefs/super.c
index 29cd71445a94..4831010c0dfd 100644
--- a/fs/bcachefs/super.c
+++ b/fs/bcachefs/super.c
@@ -856,7 +856,7 @@ static struct bch_fs *bch2_fs_alloc(struct bch_sb *sb, 
struct bch_opts opts)
            bch2_fs_compress_init(c) ?:
            bch2_fs_ec_init(c) ?:
            bch2_fs_fsio_init(c) ?:
-           bch2_fs_fs_io_buffered_init(c);
+           bch2_fs_fs_io_buffered_init(c) ?:
            bch2_fs_fs_io_direct_init(c);
        if (ret)
                goto err;
-- 
2.39.2

Reply via email to