On Thu, Sep 14, 2023 at 05:04:49PM +0800, Jiapeng Chong wrote: > No functional modification involved. > > fs/bcachefs/alloc_foreground.c:514: warning: expecting prototype for > bch_bucket_alloc(). Prototype was for bch2_bucket_alloc_trans() instead. > > Reported-by: Abaci Robot <[email protected]> > Closes: https://bugzilla.openanolis.cn/show_bug.cgi?id=6584 > Signed-off-by: Jiapeng Chong <[email protected]> > ---
JFYI, it seems like the patch series is oddly threaded with patch 9/9 being the "cover letter..?" Also, what's the granularity of the patches here? Per robot filed bug? Per source file? I don't think it really matters for this particular series, though personally I would probably squash these down into one upon merge (and prefer to see any further patches of this nature similarly condensed). Brian > fs/bcachefs/alloc_foreground.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/fs/bcachefs/alloc_foreground.c b/fs/bcachefs/alloc_foreground.c > index e02749ddc362..10a7979707ef 100644 > --- a/fs/bcachefs/alloc_foreground.c > +++ b/fs/bcachefs/alloc_foreground.c > @@ -502,7 +502,7 @@ static struct open_bucket > *bch2_bucket_alloc_freelist(struct btree_trans *trans, > } > > /** > - * bch_bucket_alloc - allocate a single bucket from a specific device > + * bch2_bucket_alloc_trans - allocate a single bucket from a specific device > * > * Returns index of bucket on success, 0 on failure > */ > -- > 2.20.1.7.g153144c >
