On Tue, Sep 26, 2023 at 12:13:33PM -0400, Kent Overstreet wrote: > On Tue, Sep 26, 2023 at 05:41:37PM +0300, Dan Carpenter wrote: > > On Tue, Sep 19, 2023 at 04:56:59PM -0400, Kent Overstreet wrote: > > > On Fri, Sep 15, 2023 at 03:57:34PM +0300, Dan Carpenter wrote: > > > > Hello Kent Overstreet, > > > > > > > > The patch 93a640e2570b: "bcachefs: GFP_NOIO -> GFP_NOFS" from May 28, > > > > 2023 (linux-next), leads to the following Smatch static checker > > > > warning: > > > > > > So the smatch warnings are pretty hard for me to deal with - it appears > > > you're testing each individual commit, which is what _I_ normally like > > > to do, except in this case there's no way I'm applying all the fixes to > > > individual commits in a 3k commit branch. > > > > > > And, dealing with the back-and-forth of going through emails is also a > > > bit much, I'm going to need to get smatch integrated into my CI. > > > > > > But... > > > > > > smatch doesn't build on debian. > > > > > > Can we get that fixed? > > > > It should. I'm using it on Debian. This should be a complete list of > > the required packages. Let me know if that's not complete. > > > > apt-get install gcc make sqlite3 libsqlite3-dev libdbd-sqlite3-perl > > libssl-dev libtry-tiny-perl > > What of the llvm dependency? I could only get it to build when I > disabled that, is that dependency important?
No, that doesn't matter. > > It also consistently segfaults on the bcachefs code. There were some problems parsing bcachefs initially but I pushed the fixes for that two weeks ago. Can you give me the filename and your .config? Or even better would be to run smatch_scripts/kchecker --valgrind path/to/file.c and send the stack trace. regards, dan carpenter
