On Tue, Nov 14, 2023 at 08:19:04AM -0500, Brian Foster wrote: > On Fri, Nov 10, 2023 at 11:31:44AM -0500, Kent Overstreet wrote: > > + /* > > + * First, attempt to replay keys in sorted order. This is more > > + * efficient, but some might fail if that would cause a journal > > + * deadlock. > > + */ > > What does "sorted order" mean here vs. when we sort by journal seq > below?
Btree key order - so better locality in the btree. > > + bch2_trans_put(trans); > > + trans = NULL; > > + > > Nit: This looks spurious w/ the exit path, just FWIW. It's because flush_all_pins() is going to internally use a btree_trans, and we can't have two btree_trans in the same thread - I'll add a comment.
