On Tue, Jan 16, 2024 at 06:43:09PM -0500, Alex Xu (Hello71) wrote:
> Technically the comma is equivalent here, but it's confusing and will
> break if it becomes the last line in the block.
>
> Fixes: e99d90c4977 ("bcachefs: fix incorrect usage of REQ_OP_FLUSH")
>
> Signed-off-by: Alex Xu (Hello71) <[email protected]>
> ---
> fs/bcachefs/journal_io.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/fs/bcachefs/journal_io.c b/fs/bcachefs/journal_io.c
> index f074a6205bf8..7b2256e18132 100644
> --- a/fs/bcachefs/journal_io.c
> +++ b/fs/bcachefs/journal_io.c
> @@ -1989,7 +1989,7 @@ CLOSURE_CALLBACK(bch2_journal_write)
>
> bio = ca->journal.bio;
> bio_reset(bio, ca->disk_sb.bdev,
> - REQ_OP_WRITE | REQ_PREFLUSH),
> + REQ_OP_WRITE | REQ_PREFLUSH);
> bio->bi_end_io = journal_write_endio;
> bio->bi_private = ca;
> closure_bio_submit(bio, cl);
> --
> 2.43.0
>
Thanks, I'm going to squash this in with the commit that introduced it
