On Fri, Jan 19, 2024 at 04:32:44PM -0500, Kent Overstreet wrote: > > I've got a new bug report with this patch: > https://www.reddit.com/r/bcachefs/comments/19a2u3c/error_writing_journal_entry/ > > We seem to be geting -EOPNOTSUPP back from REQ_OP_FLUSH?
With the patch you are replying to you will not get -EOPNOTSUPP for REQ_OP_FLUSH?, because bcachefs won't send it as it's supposed to. Without this patch as in current mainline you will get -EOPNOTSUPP because sending REQ_OP_FLUSH and finally check for that to catch bugs like the one fixed with this patch.
