This email thread has gone very badly and I'm definitely 50% responsible
for that. I apologize.
On Wed, Jan 31, 2024 at 01:57:58PM -0500, Kent Overstreet wrote:
> On Wed, Jan 31, 2024 at 09:43:14PM +0300, Dan Carpenter wrote:
>
> > Come on Kent, don't pretend like I haven't pointed out over a dozen
> > bcachefs bugs since it was merged... I'm just saying the comments
> > weren't obvious here.
>
> Most of them weren't real bugs, just places where I tweaked the code to
> please the static analyzer; I believe the number of actual bugs was more
> like 3-4.
>
That's not true... I really try avoiding make the static checker happy
patches.
The only one I see which was obviously just to make the checker happy
is commit 4b33a1916a35 ("bcachefs: bch2_ioctl_disk_resize_journal():
check for integer truncation") here was my bug report for that:
https://lore.kernel.org/all/[email protected]/
There were three other patches where it was like we have an "if (ret)"
but the "ret = " assignment was accidentally left off, but I consider
those real bugs because obviously the "ret = " assignment wasn't left
off deliberately.
Here is the whole list.
$ git log --oneline --grep=Carpenter fs/bcachefs/
03cc1e67a243 bcachefs: Fix null ptr deref in bch2_backpointer_get_node()
97ecc23632fa bcachefs: Fix strndup_user() error checking
cfda31c03315 bcachefs: drop journal lock before calling journal_write
4b33a1916a35 bcachefs: bch2_ioctl_disk_resize_journal(): check for integer
truncation
75e0c4789b62 bcachefs: Fix error checks in bch2_chacha_encrypt_key()
a55fc65eb2c7 bcachefs: Fix an overflow check
f7f6943a8c6d bcachefs: Fix copy_to_user() usage in flush_buf()
d67a72bfc92b bcachefs: snapshot: Add missing assignment in
bch2_delete_dead_snapshots()
1f12900ab523 bcachefs: fs-ioctl: Fix copy_to_user() error code
b6c22147e0fc bcachefs: acl: Add missing check in bch2_acl_chmod()
e9a0a26ed05a bcachefs: acl: Uninitialized variable in bch2_acl_chmod()
867c1fe0187f bcachefs: fix error checking in bch2_fs_alloc()
4ba985b84de6 bcachefs: chardev: fix an integer overflow (32 bit only)
301e0237cadf bcachefs: chardev: return -EFAULT if copy_to_user() fails
regards,
dan carpenter
