On Fri, Feb 16, 2024 at 07:58:34AM +0800, Su Yue wrote: > > On Thu 15 Feb 2024 at 12:16, Brian Foster <[email protected]> wrote: > > > bch2_direct_IO_read() checks the request offset and size for sector > > alignment and then falls through to a couple calculations to shrink > > the size of the request based on the inode size. The problem is that > > these checks round up to the fs block size, which runs the risk of > > underflowing iter->count if the block size happens to be large > > enough. This is triggered by fstest generic/361 with a 4k block > > size, which subsequently leads to a crash. To avoid this crash, > > check that the shorten length doesn't exceed the overall length of > > the iter. > > > > Signed-off-by: Brian Foster <[email protected]> > > > LGTM. > Reviewed-by: Su Yue <[email protected]> > > Since imap.google.com is blocked by GFW, I use my personal email address > in mu4e + emacs hosting on remote machine daily. > I am no clear what is required(gpg?) if I use my personal address to > give a review by in my employer address.
Most people don't gpg sign their regular emails, just pull requests, so I'm not going to sweat it :)
