On Tue, May 07, 2024 at 06:44:30PM +0200, Petr Vorel wrote: > > On Tue, May 07, 2024 at 05:37:57PM +0200, Petr Vorel wrote: > > > Move BCACHEFS_STATFS_MAGIC value to UAPI <linux/magic.h> under > > > BCACHEFS_SUPER_MAGIC definition (use common approach for name) and reuse > > > the > > > definition in bcachefs_format.h BCACHEFS_STATFS_MAGIC. > > > > There are other bcachefs magic definitions: BCACHE_MAGIC, BCHFS_MAGIC, > > > which use UUID_INIT() and are used only in libbcachefs. Therefore move > > > only BCACHEFS_STATFS_MAGIC value, which can be used outside of > > > libbcachefs for f_type field in struct statfs in statfs() or fstatfs(). > > > > Suggested-by: Su Yue <[email protected]> > > > Signed-off-by: Petr Vorel <[email protected]> > > > --- > > > I was thinking you'd just rename the STATFS_MAGIC def locally as well, > > but whatever.. LGTM, thanks for the tweaks! > > Ah, I thought it'd be more readable this way from bcachefs point. > Kent, just let me know if you prefer Brian's way and I'll send v4.
It's in my tree now :)
