On Sat, May 25, 2024 at 01:36:19PM -0600, Thomas Bertschinger wrote:
> The output of mount options such as "metadata_target" in `/proc/mounts`
> uses the full path to the device.
> 
> mount(8) from util-linux uses the output from `/proc/mounts` to pass
> existing mount options when performing a remount, so bcachefs should
> accept as input the same form that it prints as output.
> 
> Without this change:
> 
> $ mount -t bcachefs -o metadata_target=vdb /dev/vdb /mnt
> $ strace mount -o remount /mnt
> ...
> fsconfig(4, FSCONFIG_SET_STRING, "metadata_target", "/dev/vdb", 0) = -1 
> EINVAL (Invalid argument)
> ...
> 
> Signed-off-by: Thomas Bertschinger <[email protected]>

Applied

Reply via email to