On Thu, Jun 13, 2024 at 9:40 PM Kent Overstreet <[email protected]> wrote: > > On Tue, Jun 04, 2024 at 10:43:22AM +0300, Ariel Miculas wrote: > > Add a new source command line argument which specifies the directory > > tree that will be copied onto the newly formatted bcachefs filesystem. > > > > This commit also fixes an issue in copy_link where uninitialized data is > > copied into the symlink because of a round_up of the buffer size. > > > > Signed-off-by: Ariel Miculas <[email protected]> > > --- > > +enum COPY_TYPE { > > + COPY, > > + MIGRATE > > +}; > > enums need to be namespaced in C, do > > enum bch_migrate_type { > BCH_MIGRATE_copy, > BCH_MIGRATE_migrate, > }; > > this follows existing bcachefs conventions; if we do an enum-to-str > table later we don't have to deal with renaming the enum or silly > uppercased names in to_text() functions > > Other than that looks good - if you can do that as a fixup patch I'll go > ahead and apply the series.
I can do a fixup patch or send a v2 patch series, which option do you prefer? > > Thanks!
