On Fri, Jun 14, 2024 at 03:36:22PM +0100, Matthew Wilcox wrote: > On Fri, Jun 14, 2024 at 10:50:30AM +0000, Pankaj Raghav (Samsung) wrote: > > ret = bch2_filemap_get_contig_folios_d(mapping, pos, end, > > - FGP_LOCK|FGP_WRITE|FGP_STABLE|FGP_CREAT, > > - mapping_gfp_mask(mapping), > > - &fs); > > + FGP_WRITEBEGIN, > > + mapping_gfp_mask(mapping), &fs); > > Don't change the indentation here. In the next patch it makes the > lines too long.
I used clangd to do the formatting. I will probably stick without changing the format in this patch Thanks. > > In general, don't change the indentation. It's been one of the biggest > pains of the folio conversion. "Oh, you changed the name of this > function and now the arguments don't line up". Don't line up the > arguments with the opening paren.
