On Mon, Aug 26, 2024 at 01:08:29AM GMT, Thorsten Blum wrote: > On 26. Aug 2024, at 00:56, Kent Overstreet <[email protected]> wrote: > > On Sun, Aug 25, 2024 at 10:41:55PM GMT, Thorsten Blum wrote: > >> On 25. Aug 2024, at 20:43, Kent Overstreet <[email protected]> > >> wrote: > >>> On Sun, Aug 25, 2024 at 03:36:02PM GMT, Thorsten Blum wrote: > >>>> Add the __counted_by compiler attribute to the flexible array members > >>>> devs to improve access bounds-checking via CONFIG_UBSAN_BOUNDS and > >>>> CONFIG_FORTIFY_SOURCE. > >>>> > >>>> Increment nr_devs before adding a new device to the devs array and > >>>> adjust the array indexes accordingly. > >>> > >>> The nr_devs changes are pretty gross - please add a helper for that > >> > >> How about a macro in replicas_format.h like this: > >> > >> #define replicas_entry_add_dev(e, d) ({ > >> (e)->nr_devs++; > >> (e)->devs[(e)->nr_devs - 1] = (d); > >> }) > > > > Does it need to be a macro? > > It could also be two functions, one for each struct. > > Which one do you prefer?
I suppose the macro fits with what we're doing for replicas_entry_bytes() - that's alright then
