On Mon, 23 Sep 2024 17:40:05 -0400, Kent Overstreet wrote: > On Mon, Sep 23, 2024 at 02:39:31PM GMT, David Disseldorp wrote: ... > > > int ret = buf.allocation_failure ? -ENOMEM : 0; > > > > Should the copy from buf into seq occur if allocation_failure > > is already flagged? I'd expect seq_puts() to have oopsed. > > That's a good point; it might be the first allocation that fails, not a > realloc. It won't be in practice, buuuut....
I've sent a follow-up patch to avoid the seq_puts(seq, NULL). Feel free to squash it in with this if you like.
