Re: [PATCH] bcachefs: fast exit when darray_make_room failed

[zhangjianhua (E)]

在 2024/9/24 9:42, Hongbo Li 写道:

In downgrade_table_extra, the return value is needed. When it
return failed, we should exit immediately.

补丁标题讲的是函数失败后快速退出，很难理解fast的意义。

最好描述下当前代码会有什么问题，这样更有说服力。

Fixes: 7773df19c35f ("bcachefs: metadata version bucket_stripe_sectors")
Signed-off-by: Hongbo Li <lihongb...@huawei.com>
---
  fs/bcachefs/sb-downgrade.c | 4 +++-
  1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/fs/bcachefs/sb-downgrade.c b/fs/bcachefs/sb-downgrade.c
index c7e4cdd3f6a5..6f0493f79959 100644
--- a/fs/bcachefs/sb-downgrade.c
+++ b/fs/bcachefs/sb-downgrade.c
@@ -353,7 +353,9 @@ int bch2_sb_downgrade_update(struct bch_fs *c)
                for (unsigned i = 0; i < src->nr_errors; i++)
                        dst->errors[i] = cpu_to_le16(src->errors[i]);

- downgrade_table_extra(c, &table);

+               ret = downgrade_table_extra(c, &table);
+               if (ret)
+                       goto out;

if (!dst->recovery_passes[0] &&

                    !dst->recovery_passes[1] &&