Re: [PATCH] bcachefs-tools: remove double start for fs when migrate

[Hongbo Li]

This patch is for bcachefs-tools to solve issue: #730. :)

On 2024/9/30 17:39, Hongbo Li wrote:

bcachefs migrate will start fs twice, it will triggle BUG_ON
condition and other troubles. Actually, we only need to start
fs once.

Fixes: 38b8d01c4cf8 ("Update bcachefs sources to 481b5f343248 bcachefs: Better error 
messages for missing inodes in fsck")
Closes: https://github.com/koverstreet/bcachefs/issues/730
Signed-off-by: Hongbo Li <lihongb...@huawei.com>
---
  c_src/cmd_migrate.c | 4 ----
  1 file changed, 4 deletions(-)

diff --git a/c_src/cmd_migrate.c b/c_src/cmd_migrate.c
index a5b7786d..f8b4acc8 100644
--- a/c_src/cmd_migrate.c
+++ b/c_src/cmd_migrate.c
@@ -268,10 +268,6 @@ static int migrate_fs(const char           *fs_path,
        if (ret)
                die("Error allocating buckets_nouse: %s", bch2_err_str(ret));

- ret = bch2_fs_start(c);

-       if (IS_ERR(c))
-               die("Error starting new filesystem: %s", bch2_err_str(ret));
-
        mark_unreserved_space(c, extents);

ret = bch2_fs_start(c);