On Tue, Feb 11, 2025 at 01:02:28AM +0800, Alan Huang wrote: > On Feb 11, 2025, at 00:25, Kent Overstreet <[email protected]> wrote: > > > > On Mon, Feb 10, 2025 at 11:04:21AM +0800, Alan Huang wrote: > >> Since we don't merge compressed extents, uncompressed_size should be > >> equal to compressed_size, use uncompressed_size to clarify the intention. > > > > compressed_size actually describes the intention better here, it refers > > to size ondisk, and we're checking if the extents are contiguous on disk > > But we don’t merge compressed extents. > > There is is_compressed check above (below compressed_size check in the past > as the history says) > > Not sure if it’s my problem, but I spent hours before figuring out that we're > checking if the extents are contiguous on disk.
You're also checking p.ptr.offset, which is the offset on disk...
