Re: [PATCH] [PATCH resend] bcachefs-tools: make targets of subvolume create/delete required

[Kent Overstreet]

On Thu, Mar 27, 2025 at 02:37:19PM +0800, Integral wrote:
> Currently, when no targets are provided for "bcachefs subvolume create" or
> "bcachefs subvolume delete", it will exit silently with code 0. Make targets
> (arguments) required to solve this problem.
> 
> This patch solves issue https://github.com/koverstreet/bcachefs/issues/766.
> 
> Signed-off-by: Integral <integ...@archlinuxcn.org>

Thanks, applied

> ---
>  src/commands/subvolume.rs | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/src/commands/subvolume.rs b/src/commands/subvolume.rs
> index 7df20819..6f5f2f2b 100644
> --- a/src/commands/subvolume.rs
> +++ b/src/commands/subvolume.rs
> @@ -18,12 +18,14 @@ enum Subcommands {
>      #[command(visible_aliases = ["new"])]
>      Create {
>          /// Paths
> +        #[arg(required = true)]
>          targets: Vec<PathBuf>,
>      },
>  
>      #[command(visible_aliases = ["del"])]
>      Delete {
>          /// Path
> +        #[arg(required = true)]
>          targets: Vec<PathBuf>,
>      },
>  
> -- 
> 2.49.0
>