On Fri, Dec 09, 2016 at 10:30:34AM -0800, Christoph Hellwig wrote: > On Fri, Dec 09, 2016 at 10:45:30AM -0700, Scott Bauer wrote: > > Now, with this in mind, it sort of makes sense to move this from > > block/ back into lib/ and interface with the character dev. Instead > > of passing around block_devices, we can pass around struct file *'s. > > > > Even the character device is always backed by the queues, and I'd really > not prefer to have a struct file here - that's not useful at all > for in-kernel users.
Is your main concern that if an in-kernel user wants to use this functionality they have to pass us a block device pointer, and may not be able to? Is that why you wanted to pass a function pointer to the code because a driver/kernel-user can probably always have that availiable to send to us? -- To unsubscribe from this list: send the line "unsubscribe linux-block" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html
