Re: [PATCH 2/9] virtio_pci: use shared interrupts for virtqueues

[Jason Wang]

On 2017年01月27日 16:16, Christoph Hellwig wrote:

+               snprintf(vp_dev->msix_names[i + 1],
+                        sizeof(*vp_dev->msix_names), "%s-%s",
                         dev_name(&vp_dev->vdev.dev), names[i]);
                err = request_irq(pci_irq_vector(vp_dev->pci_dev, msix_vec),
-                                 vring_interrupt, 0,
-                                 vp_dev->msix_names[msix_vec],
-                                 vqs[i]);
+                                 vring_interrupt, IRQF_SHARED,
+                                 vp_dev->msix_names[i + 1], vqs[i]);

Do we need to check per_vq_vectors before dereferencing msix_names[i + 1] ?

Thanks
--
To unsubscribe from this list: send the line "unsubscribe linux-block" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html