On Mon, Mar 27, 2017 at 10:43:58AM -0700, Omar Sandoval wrote: > From: Omar Sandoval <[email protected]> > > blk_alloc_queue_node() already allocates q->stats, so > blk_mq_init_allocated_queue() is overwriting it with a new allocation. > > Fixes: a83b576c9c25 ("block: fix stacked driver stats init and free") > Signed-off-by: Omar Sandoval <[email protected]> > --- > block/blk-mq.c | 4 ---- > 1 file changed, 4 deletions(-) > > diff --git a/block/blk-mq.c b/block/blk-mq.c > index c212b9644a9f..9c6b39bd8358 100644 > --- a/block/blk-mq.c > +++ b/block/blk-mq.c > @@ -2212,10 +2212,6 @@ struct request_queue > *blk_mq_init_allocated_queue(struct blk_mq_tag_set *set, > /* mark the queue as mq asap */ > q->mq_ops = set->ops; > > - q->stats = blk_alloc_queue_stats(); > - if (!q->stats) > - goto err_exit; > - > q->poll_cb = blk_stat_alloc_callback(blk_mq_poll_stats_fn, > blk_stat_rq_ddir, 2, q); > if (!q->poll_cb) > -- > 2.12.1 >
Reviewed-by: Ming Lei <[email protected]> -- Ming
