Hi,

On 12/04/17 09:16, Christoph Hellwig wrote:
On Wed, Mar 29, 2017 at 12:56:16PM +0200, Jan Kara wrote:
Similarly to set_bdev_super() GFS2 just used block device reference to
bdi. Convert it to properly getting bdi reference. The reference will
get automatically dropped on superblock destruction.
Hmm, why iisn't gfs2 simply using the generic mount_bdev code?

Otherwise looks fine:

Reviewed-by: Christoph Hellwig <h...@lst.de>

It is more or less. However we landed up copying it because we needed a slight modification in order to cope with the metafs mounts. There may be scope to factor out the common parts I guess. We cannot select the root dentry until after we've parsed the mount command line, so it is really just the last part of the function that is different,

Steve.

Reply via email to