On Mon, 2017-05-01 at 18:29 +0200, [email protected] wrote: > + strlcpy(elevator_name, name, sizeof(elevator_name)); > + strstrip(elevator_name); > + ret = __elevator_change(q, elevator_name);
Hello Markus, Are you aware that the current implementation of __elevator_change() strips leading whitespace but that with your patch applied leading whitespace is no longer removed from the elevator name? If you have a look at strim() in lib/string.c you will see that in case of leading whitespace that function does not remove the leading whitespace but returns a pointer to the first non-whitespace character. Otherwise this patch looks fine to me. Bart.
